API Scribes and update old craft

API Scribes and update old craft

in API Development

Posted by: myami.7230

myami.7230

Hey everyone, so i try to make a guide for scribes with the API but when i’m searching

this for exemple on the API : https://wiki.guildwars2.com/wiki/Scribing:_Guild_Ballista

i found the item guild ballista : https://api.guildwars2.com/v2/items.json?id=42003

but not the scribes recipe so it’s because of me or because they don’t update the API ?

Thanks to have read and sorry for my error when i’m writing english is not my first language

API Scribes and update old craft

in API Development

Posted by: Lawton Campbell

Lawton Campbell

Web Programmer

Next

Hmm, either no one’s made a Guild Ballista with the new scribe recipe, or there’s a bug on my end.

I’m guessing it’s a bug.

API Scribes and update old craft

in API Development

Posted by: MatHack.4316

MatHack.4316

I haven’t seen any of the guild related Scribe recipes in the API, even though I crafted multiple types of the banners myself, as well as the odd decoration. All these are items that get put (indirectly) into the guild storage. Hopefully this info helps you find the bug.

Far Shiverpeaks

API Scribes and update old craft

in API Development

Posted by: Lawton Campbell

Previous

Lawton Campbell

Web Programmer

Next

Yup, found the bug. Not sure when I’m going to get the fix out; not sure I can get it in for the Dec. 1st release

API Scribes and update old craft

in API Development

Posted by: myami.7230

myami.7230

164 recette of scribes still not implemented on the API
thanks Xanthic to tell us it’s not still update
https://twitter.com/gw2crafts/status/673861829123178497

API Scribes and update old craft

in API Development

Posted by: Lawton Campbell

Previous

Lawton Campbell

Web Programmer

Next

164 recette of scribes still not implemented on the API
thanks Xanthic to tell us it’s not still update
https://twitter.com/gw2crafts/status/673861829123178497

Recipes won’t appear in the API until they’re crafted at least once (and then there’s a manual step where I press a button after making sure there’s no junk data). It’ll get there eventually.

API Scribes and update old craft

in API Development

Posted by: thisisit.6954

thisisit.6954

There are lvl 400 scribes out there though, so I assume there are recipes that have been done at least once to get to 400 and therefore a possible guide?

If Xanthic says there are still gaps in his guide, then is this the manual step thats missing from them being added to the API? ( I know there are ones that may not have been done once yet but I am assuming they are due to the insane cost which wouldnt factor into a scribe guide anyway).

*Just a guy looking for a scribe guide without the resources to spend thousands trying to find it himself *

API Scribes and update old craft

in API Development

Posted by: Lawton Campbell

Previous

Lawton Campbell

Web Programmer

Next

I’m not sure how/why the missing recipes aren’t appearing. By my reading, they should have been put in the whitelist queue if they’ve been used (and I have a hard time believing they haven’t been used). Made a new github issue for this and I’m going to spend some time today rooting around in the log files to try to figure out what’s going on.

API Scribes and update old craft

in API Development

Posted by: xanthic.9478

xanthic.9478

To the best of my knowledge there are not gaps in my guides related to items missing from the API. My current issue is items that exist as non-TP-able items, such as Crystalline Vials, that need to be manually added on my end.

http://gw2crafts.net/scribe.html (for current status)

I haven’t had the time until today(since the introduction of scribe) to do the context switch necessary to track down issues.

[edit] Actually I have a problem with how “guild_ingredients” were added to recipes as well. Now I need to create a lookup table so I can find the item_id from an upgrade_id. Having to check for this new field and not having the item_id of the guild ingredient in the “ingredients” section is >.> as it also means the recipe list needs to be processed at least twice.

[edit2] nm looks like there is an item id on things that have them https://api.guildwars2.com/v2/guild/upgrades/352 that I can work backwards from.

Always Current Crafting Guides: http://gw2crafts.net
Updated every 20 minutes based on current TP prices.

(edited by xanthic.9478)

API Scribes and update old craft

in API Development

Posted by: xanthic.9478

xanthic.9478

Actually, there are gaps that break things for me.

This recipe creates an item http://api.guildwars2.com/v2/recipes.json?ids=10510

This item “doesn’t exist” in https://api.guildwars2.com/v2/items.json?ids=76707

But it exists in https://api.guildwars2.com/v2/guild/upgrades/291

What is the intended behaviour here? Should I be able to find item ids that don’t exist in the items endpoint that map to an item that actually exists and would have that id if it was in the items endpoint?

Always Current Crafting Guides: http://gw2crafts.net
Updated every 20 minutes based on current TP prices.

(edited by xanthic.9478)

API Scribes and update old craft

in API Development

Posted by: Lawton Campbell

Previous

Lawton Campbell

Web Programmer

Next

What is the intended behaviour here? Should I be able to find item ids that don’t exist in the items endpoint that map to an item that actually exists and would have that id if it was in the items endpoint?

I mostly didn’t want to break existing applications by making output_item_id conditional.

Whenever output_upgrade_id is present, output_item_id is not used. There are some placeholder items that are relics of times gone by (for the interested, they’re like “Immediate” type items which are consumed before entering your inventory), but it was probably a mistake including them.

The output_upgrade_id references /v2/guild/upgrades.

API Scribes and update old craft

in API Development

Posted by: xanthic.9478

xanthic.9478

Whenever output_upgrade_id is present, output_item_id is not used.

Thanks for the followup.

https://api.guildwars2.com/v2/guild/upgrades/352 A vendor item that goes immediately into the guild inventory with an item_id on its page that is valid for the items endpoint

https://api.guildwars2.com/v2/guild/upgrades/291 a crafted item that differs only in where it enters the guild inventory from that does not have an item_id on its page (although the recipe that creates it lists one)

I realize you are talking about recipes, so this discrepant behaviour doesn’t apply. However needing to juggle two item lists(because they have overlapping id numbers so they can’t be merged) just to get all the relevant item names(in multiple languages) is too expensive for me(in terms of development time). If the item_id on the recipe page is “invalid” anyways(as in it is superseded by output_upgrade_id) and won’t be added to the items endpoint, it would be nice if it was removed outright (from that recipe) or the items endpoint gave a useful error message.

Either way I’ll leave it to someone else to created automated scribe guides.

Always Current Crafting Guides: http://gw2crafts.net
Updated every 20 minutes based on current TP prices.

API Scribes and update old craft

in API Development

Posted by: Lawton Campbell

Previous

Lawton Campbell

Web Programmer

If the item_id on the recipe page is “invalid” anyways(as in it is superseded by output_upgrade_id) and won’t be added to the items endpoint, it would be nice if it was removed outright (from that recipe) or the items endpoint gave a useful error message.

I’m of the opinion that the endpoint shouldn’t dump out bogus values; I’ve made a github issue and will probably remove it at some point. My original concern was that removing it would break existing applications, but in hindsight, leaving it in breaks existing applications in a more subtle and more confusing manner.

:(

API Scribes and update old craft

in API Development

Posted by: Illconceived Was Na.9781

Illconceived Was Na.9781

However …just to get all the relevant item names(in multiple languages) is too expensive for me(in terms of development time). …

Either way I’ll leave it to someone else to created automated scribe guides.

Sorry to hear that. I’m sure that many (besides myself) were looking forward to gw2crafts.net including a scribing guide.

John Smith: “you should kill monsters, because killing monsters is awesome.”